Fix the build so setupPublishCore enables the optimizer again#6997
Merged
dwijnand merged 1 commit intoscala:2.13.xfrom Aug 2, 2018
Merged
Fix the build so setupPublishCore enables the optimizer again#6997dwijnand merged 1 commit intoscala:2.13.xfrom
dwijnand merged 1 commit intoscala:2.13.xfrom
Conversation
Regressed in scala#6964 Before: ``` $ sbt setupPublishCore 'show library/scalacOptions' 'show reflect/scalacOptions' 'show compiler/test:scalacOptions' 'show test/scalacOptions' [info] Loading global plugins from /Users/jz/.sbt/0.13/plugins [info] Loading project definition from /Users/jz/code/scala/project/project [info] Loading project definition from /Users/jz/code/scala/project [info] Resolving key references (11393 settings) ... [info] *** Welcome to the sbt build definition for Scala! *** [info] Check README.md for more information. [info] *** Welcome to the sbt build definition for Scala! *** [info] Check README.md for more information. [info] * -Xlint:-nullary-override,-inaccessible,_ [success] Total time: 0 s, completed 02/08/2018 12:33:38 PM [info] * -Xlint:-nullary-override,-inaccessible,_ [success] Total time: 0 s, completed 02/08/2018 12:33:38 PM [info] * -Xlint:-nullary-override,-inaccessible,_ [success] Total time: 0 s, completed 02/08/2018 12:33:38 PM [info] * [success] Total time: 0 s, completed 02/08/2018 12:33:38 PM ``` After: ``` $ sbt setupPublishCore 'show library/scalacOptions' 'show reflect/scalacOptions' 'show compiler/test:scalacOptions' 'show test/scalacOptions' [info] Loading global plugins from /Users/jz/.sbt/0.13/plugins [info] Loading project definition from /Users/jz/code/scala/project/project [info] Loading project definition from /Users/jz/code/scala/project [info] Resolving key references (11393 settings) ... [info] *** Welcome to the sbt build definition for Scala! *** [info] Check README.md for more information. [info] *** Welcome to the sbt build definition for Scala! *** [info] Check README.md for more information. [info] * -opt:l:inline [info] * -opt-inline-from:scala/** [info] * -Xlint:-nullary-override,-inaccessible,_ [info] * -sourcepath [info] * /Users/jz/code/scala/src/library [success] Total time: 0 s, completed 02/08/2018 12:31:18 PM [info] * -opt:l:inline [info] * -opt-inline-from:scala/** [info] * -Xlint:-nullary-override,-inaccessible,_ [success] Total time: 0 s, completed 02/08/2018 12:31:18 PM [info] * -opt:l:inline [info] * -opt-inline-from:scala/** [info] * -Xlint:-nullary-override,-inaccessible,_ [success] Total time: 0 s, completed 02/08/2018 12:31:18 PM [info] * -opt:l:inline [info] * -opt-inline-from:scala/** [success] Total time: 0 s, completed 02/08/2018 12:31:18 PM ```
Merged
dwijnand
approved these changes
Aug 2, 2018
Member
dwijnand
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure if this disables it for the junit source code (depends if they're compile:compiled or test:compiled). But either way the regression fix trumps this.
som-snytt
reviewed
Aug 2, 2018
Contributor
som-snytt
left a comment
There was a problem hiding this comment.
Thanks. Adding to my list of things learned the hard way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed in #6964
Before:
After: