Increase the counter while looking for the ScalaSignature annotation#6816
Merged
retronym merged 1 commit intoscala:2.13.xfrom Jun 18, 2018
Merged
Increase the counter while looking for the ScalaSignature annotation#6816retronym merged 1 commit intoscala:2.13.xfrom
retronym merged 1 commit intoscala:2.13.xfrom
Conversation
Scala classfiles have a `Scala` classfile attribute as a marker. The pickle is stored in the `ScalaSignature` RuntimeVisibleAnnotation. After seeing the marker attribute, we traverse the annotations until finding the signature. But in case the classfile doesn't actually have the signature annotation, the loop would overflow.
retronym
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scala classfiles have a
Scalaclassfile attribute as a marker. Thepickle is stored in the
ScalaSignatureRuntimeVisibleAnnotation.After seeing the marker attribute, we traverse the annotations until
finding the signature. But in case the classfile doesn't actually have
the signature annotation, the loop would overflow.