Remove element type from mutable.ArraySeq.(elemTag|array)#6648
Merged
lrytz merged 1 commit intoscala:2.13.xfrom May 30, 2018
Merged
Remove element type from mutable.ArraySeq.(elemTag|array)#6648lrytz merged 1 commit intoscala:2.13.xfrom
lrytz merged 1 commit intoscala:2.13.xfrom
Conversation
lrytz
requested changes
May 15, 2018
Member
lrytz
left a comment
There was a problem hiding this comment.
We have the same issue for immutable.ArraySeq
scala> collection.immutable.ArraySeq.untagged(1,2,3).unsafeArray
java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [I
... 33 elided
Could you also add some tests?
ArraySeqs (both mutable and immutable) can be boxed or unboxed for primitives and could have been created with an `Array[AnyRef]` for arbitrary reference types, so we cannot guarantee any specific element type for the backing array.
Contributor
Author
|
Updated to cover |
szeiger
commented
May 30, 2018
| /** The wrapped mutable `Array` that backs this `ArraySeq`. Any changes to this array will break | ||
| * the expected immutability. */ | ||
| def unsafeArray: Array[A @uncheckedVariance] | ||
| // uncheckedVariance should be safe: Array[A] for reference types A is covariant at the JVM level. Array[A] for |
Contributor
Author
There was a problem hiding this comment.
So much for my assumptions...
lrytz
approved these changes
May 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArraySeq can be boxed or unboxed for primitives and could have been
created with an
Array[AnyRef]for arbitrary reference types, so wecannot guarantee any specific element type for the backing array.
Fixes scala/bug#10851