Avoid constraints of the wrong kind between TypeVars#6333
Closed
joroKr21 wants to merge 1 commit intoscala:2.13.xfrom
Closed
Avoid constraints of the wrong kind between TypeVars#6333joroKr21 wants to merge 1 commit intoscala:2.13.xfrom
joroKr21 wants to merge 1 commit intoscala:2.13.xfrom
Conversation
bbc4064 to
06070a6
Compare
Member
Author
|
/sync |
Contributor
|
You might want to take a look at this earlier attempt of mine in the same general area: #6127. I haven't had time to get it past WIP state. |
Member
Author
|
Ah, I missed that. Thanks for pointing it out. Another problem with the type variable solver (or glb/lub, depending on your POV) is that the order of constraints matters (scala/bug#10740 and scala/bug#10686). |
Contributor
|
There are a lot of problems with the solver currently. I think it could do with a complete overhaul. |
When solving a list of type variables, bounds between them should not be added as constraints when they are of different kinds. Fixes scala#8602 and fixes scala#10722
06070a6 to
d2b1389
Compare
Merged
Contributor
|
Thanks! Incorporating tests in my follow-up PR, which also incorporates a variant of your fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When solving a list of type variables, bounds between them should
not be added as constraints when they are of different kinds.
Fixes scala/bug#8602 and fixes scala/bug#10722