Partial unification unconditional; deprecate -Xexperimental#6309
Conversation
|
Does it make sense to preserve the |
|
According to @adriaanm, no, because |
|
Maybe there’s another possibility here, of doing something stronger than deprecation, namely refusing to accept the flag, but also printing something more helpful than “huh? -Ypartial-unification`? never heard of it”. (thinking out loud) |
Sounds like @eed3si9n's "Restligeist macro" idea: https://twitter.com/eed3si9n/status/770584274819055617 We have those in sbt 1 for the old sbt 0.9-0.12 operators: https://github.com/sbt/sbt/blob/v1.1.1/main-settings/src/main/scala/sbt/std/TaskMacro.scala#L129-L130. |
|
@adriaanm Jenkins seems wedged on this one, won't rebuild @milessabin try rebasing? |
f03ab36 to
54f9a43
Compare
|
Rebased. |
|
The jenkins upgrade appears to have broken the job notification plugin. No idea what's wrong. The start of job notification arrives fine, end of job is logged as sent on the jenkins side, but never arrives at scabot. 🤔 |
54f9a43 to
a942d33
Compare
|
Rebased. |
|
Is there any more that needs to be done before this can be merged? |
Partial unification is now enabled unless -Xsource:2.12 is specified. The -Ypartial-unification flag has been removed and the -Xexperimental option, which is now redundant, has been deprecated.
a942d33 to
7d5e0b0
Compare
|
Rebased ... also ... bump! |
|
@adriaanm is there anything blocking this from being merged now? |
|
Hurrah! |
Partial unification is now enabled unless
-Xsource:2.12is specified. The-Ypartial-unificationflag has been removed and the-Xexperimentaloption, which is now redundant, has been deprecated.