Merged
Conversation
It'd be good to use the latest version. From sbt-jmh version 0.2.10, Flight Recorder / Java Mission Control is available[1], which would be nice. [1] https://github.com/ktoso/sbt-jmh#using-oracle-flight-recorder
Member
|
review by @performantdata ? |
Contributor
|
LGTM, as long as it compiles and runs, which I'd expect with a minor JMH release. You'll need to test that manually; the project tests don't check that automatically. |
Member
|
I tested it by running |
Member
|
thanks @monkey-mas! |
Contributor
Author
|
Thanks alot for your review! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be good to use the latest version( with the latest JMH version
1.14.1). From sbt-jmh version0.2.10, Flight Recorder / Java Mission Control is available[1], which would be nice.[1] https://github.com/ktoso/sbt-jmh#using-oracle-flight-recorder