Do not build partest-javaagent and partest-extras for pack#5414
Merged
adriaanm merged 1 commit intoscala:2.12.0from Sep 26, 2016
Merged
Do not build partest-javaagent and partest-extras for pack#5414adriaanm merged 1 commit intoscala:2.12.0from
pack#5414adriaanm merged 1 commit intoscala:2.12.0from
Conversation
Building them as part of `dist/mkQuick` (and thus, by extension, `dist/mkPack`) was not necessary in the first place. Partest does not rely on these tasks for its dependencies. And when we do build the jars, they now go into their standard location under `target` instead of `build/pack/lib` so they don’t confuse sbt (see sbt/sbt#2748).
Contributor
|
LGTM |
Contributor
|
Adding this one to my mental list of unexpected consequences of insourcing scalacheck. |
This was referenced Sep 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building them as part of
dist/mkQuick(and thus, by extension,dist/mkPack) was not necessary in the first place. Partest does notrely on these tasks for its dependencies.
And when we do build the jars, they now go into their standard location
under
targetinstead ofbuild/pack/libso they don’t confusesbt (see sbt/sbt#2748).