Avoid omitting constant typed vals in constructors#5395
Merged
retronym merged 1 commit intoscala:2.12.0from Sep 15, 2016
Merged
Avoid omitting constant typed vals in constructors#5395retronym merged 1 commit intoscala:2.12.0from
retronym merged 1 commit intoscala:2.12.0from
Conversation
Member
Author
Fix for regression in 2.12.0-RC1 compiling shapeless tests. They were given the same treatment as vals that are members of classes on the definition side without the requisite transformation of references to the val to fold the constant into references. This commit limits the transform to members of classes. Co-Authored-By: Miles Sabin <miles@milessabin.com>
Contributor
|
I'm happy to report that the shapeless tests compile (albeit very slowly, more on this later) after this PR. I'm seeing a problem running tests, but I think that must be unrelated (running |
Member
https://groups.google.com/d/msg/scala-internals/7BNLnKQp4f0/rh6vlf2GFQAJ |
Contributor
|
Sorry, I should have posted that here directly ... |
Member
|
LGTM - a really interesting test case that requires collaboration of various language features..! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for regression in 2.12.0-RC1 compiling shapeless tests.
They were given the same treatment as vals that are
members of classes on the definition side without the
requisite transformation of references to the val to
fold the constant into references.
This commit limits the transform to members of classes.