SI-8774 Null link fields in mutable LinkedHashMap (and friends) on remove#5295
Merged
szeiger merged 1 commit intoscala:2.12.xfrom Jul 22, 2016
varming:cvarming/nepotism
Merged
SI-8774 Null link fields in mutable LinkedHashMap (and friends) on remove#5295szeiger merged 1 commit intoscala:2.12.xfrom varming:cvarming/nepotism
szeiger merged 1 commit intoscala:2.12.xfrom
varming:cvarming/nepotism
Conversation
Contributor
|
LGTM. Considering the discussion in #3911 it would make sense to keep SI-8774 open or open a new ticket for possible changes to the collection specification regarding fail-fast behavior for 2.13. |
Contributor
Author
|
Dear @szeiger, Thank you for the review. By fast fail I assume you are hinting at throwing ConcurrentModificationException exceptions. I would open a new ticket to get a fresh discussion about potential implementations and their performance impact. |
Contributor
|
Great, thanks. Please link to #3911 and SI-8774 in the new ticket. |
Contributor
Author
|
@szeiger, I don't have an jira account, do you mind opening the ticket? |
Contributor
|
We'll also take tickets over at https://github.com/scala/scala-dev/issues. Friends don't make friends use jira :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is about time to close SI-8774.
I bootstrapped the compiler to verify that my solution does not hit the bug mentioned in SI-8774.