SI-9691 BufferedIterator should expose a headOption#5287
Merged
szeiger merged 1 commit intoscala:2.12.xfrom Jul 18, 2016
Merged
SI-9691 BufferedIterator should expose a headOption#5287szeiger merged 1 commit intoscala:2.12.xfrom
szeiger merged 1 commit intoscala:2.12.xfrom
Conversation
This exposes a new API to the BufferedIterator trait. It will return the next element of an iterator as an Option. The return will be Some(value) if there is a next value, and None if there is not a next element.
Contributor
|
LGTM. Congratulations to your first merged PR! |
Contributor
|
👍 |
Contributor
|
Btw, this broke slick: https://github.com/slick/slick/blob/master/slick/src/main/scala/slick/util/ReadAheadIterator.scala#L26 (and thus the community build: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/456/consoleFull) |
7 tasks
Contributor
|
How ironic, but we don't really have any way to avoid this sort of problem. The only solution I can think of that allows cross-building Slick is to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes a new API to the BufferedIterator trait. It will return the next element of an iterator as an Option. The return will be Some(value) if there is a next value, and None if there is not a next element.
This has been squashed and documentation put in place. Was previously covered by #5277