SI-9245 Fresher name in Try and test#5219
Merged
retronym merged 1 commit intoscala:2.11.xfrom Jun 14, 2016
Merged
Conversation
Fresh name for catcher gets a dollar. "Here, have a dollar." Test due to retronym demonstrates possible conflict. Over the lifetime of the universe, surely at least one code monkey would type in that identifier to catch a banana.
Member
|
LGTM 💵 |
Contributor
|
It sure is a catchy name, so probably good to make it uniquer. Ca-tching! |
Contributor
Author
|
18 long hours later, I'm still laughing at |
Contributor
|
😁 |
Member
|
I found similarly destitute fresh names: synthesizePartialFunction(newTermName(context.unit.fresh.newName("x"))
unit.freshTermName("nonLocalReturnKey")
unit.freshTermName("liftedTree")I don't think that the potential classes are exploitable (in terms of compiler crash or wrong semantics), but it couldn't hurt to offer them some alms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh name for catcher gets a dollar. "Here, have a dollar."
Test due to retronym demonstrates possible conflict.
Over the lifetime of the universe, surely at least one code
monkey would type in that identifier to catch a banana.