SI-9799 Keep ImportHandlers that imports implicit symbols for -Yrepl-class-based#5210
Closed
zsxwing wants to merge 1 commit intoscala:2.12.xfrom
Closed
SI-9799 Keep ImportHandlers that imports implicit symbols for -Yrepl-class-based#5210zsxwing wants to merge 1 commit intoscala:2.12.xfrom
zsxwing wants to merge 1 commit intoscala:2.12.xfrom
Conversation
Contributor
Author
|
/cc @ScrapCodes |
Contributor
|
No this change is not going to help us. Removing that line will lead to importing much more than necessary for declaring the class. It will lead to surfacing of old fixed bugs like: SPARK-1199. You can try running ReplSuite in spark for scala 2.10 by making your change as above. |
Contributor
Author
|
Closed as this will introduce other issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't know whether the implicit imports are necessary, they should be always kept.