Check left side of an assignment expression for errors; fixes SI-9781#5179
Merged
adriaanm merged 1 commit intoscala:2.12.xfrom May 24, 2016
Merged
Check left side of an assignment expression for errors; fixes SI-9781#5179adriaanm merged 1 commit intoscala:2.12.xfrom
adriaanm merged 1 commit intoscala:2.12.xfrom
Conversation
| def onError(reportError: => Tree): Tree = fun match { | ||
| case Select(qual, name) if !mode.inPatternMode && nme.isOpAssignmentName(newTermName(name.decode)) => | ||
| case Select(qual, name) | ||
| if !mode.inPatternMode && nme.isOpAssignmentName(newTermName(name.decode)) && !qual.exists(_.isErroneous) => |
Member
There was a problem hiding this comment.
I think it is sufficient to call qual.isErrorTyped, rather than traversing its components.
Contributor
Author
There was a problem hiding this comment.
I tried that but it is not. In the test case, the Apply node itself has no error. The tree looks like:
Apply(Ident(TermName("c")), List(Ident(<TermName("undefinedSymbol"): error>)))
Member
|
Could you please edit/expand the commit comment as: |
`convertToAssignment` is triggered on a type error but it doesn't seem to really care what the error is as long as the expression can be converted to an assignment expression. This patch fixes that by checking whether the qualifier of the selection contains any errors before deciding to continue with the conversion.
Contributor
Author
|
Fixed commit comment. |
Contributor
Author
|
/rebuild |
Contributor
|
LGTM -- thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertToAssignmentis triggered on a type error but it doesn't seem to really care what the error is as long as the expression can be converted to an assignment expression.This patch attempts to fix that by checking whether the left side of the expression contains any errors before deciding to continue with the conversion.