[Build] Include missing web assets in scaladoc#5093
Merged
szeiger merged 1 commit intoscala:2.12.xfrom May 20, 2016
jodersky:scaladoc-include-assets
Merged
[Build] Include missing web assets in scaladoc#5093szeiger merged 1 commit intoscala:2.12.xfrom jodersky:scaladoc-include-assets
szeiger merged 1 commit intoscala:2.12.xfrom
jodersky:scaladoc-include-assets
Conversation
Member
|
could you re-submit this to 2.11.x? this way it will also make it into 2.12.x, we merge forward regularly. |
Contributor
|
LGTM |
Member
|
this needs a rebase to fix the merge conflict. @szeiger, is it that these files are new in 2.12 scaladoc, so it's not needed in 2.11? |
Contributor
Contributor
Author
|
If you publish scala 2.12 with sbt, some assets are not included in the resulting jars and hence, scaladoc will fail. |
Contributor
Author
|
Can't reproduce this on 2.11, I assume the new assets were introduced for scaladoc 2.12 (which looks pretty cool btw :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a Scala version that is built with sbt will fail when generating docs, since some required assets are not included in the packaged Scala artifacts. This PR adds the missing assets to the sbt build definition.
cc @SethTisue, the changes are related to the sbt build