Conversation
|
review by @szeiger, as there's some code in build.sbt. |
|
Iirc, I started with a .iml file from another project that was compatible with the native SBT import. I added source JARs by hand. We could mimic the internals of that import tool ourselves to automate most of this. |
|
Hm, this doesn't compile for me, as if there was a problem with the applicative transformation in sbt's macros: |
|
Looks like I have a wrong |
|
Using it already -- works great! Would it make sense to have a shortcut task that does it all at once? |
|
Do you even need two separate tasks? Wouldn't it be sufficient to have one task that updates the IntelliJ configuration, or creates it from scratch if it doesn't yet exist? |
|
|
|
the description in the readme is not quite accurate, if you run |
|
Shall we rename that task to simply |
|
fine with me, i'll clean it up |
|
@szeiger i changed @adriaanm renamed the task to As a bonus, the dependency list for the So i think this PR is ready now. |
|
Cool! |
|
I just noticed that the I've got this one in one of my checkouts that I must have created manually:
<?xml version="1.0" encoding="UTF-8"?>
<module type="JAVA_MODULE" version="4">
<component name="NewModuleRootManager" inherit-compiler-output="true">
<exclude-output />
<content url="file://$MODULE_DIR$/../repl-jline">
<sourceFolder url="file://$MODULE_DIR$/../repl-jline" isTestSource="false" />
</content>
<orderEntry type="inheritedJdk" />
<orderEntry type="sourceFolder" forTests="false" />
<orderEntry type="module" module-name="compiler" />
<orderEntry type="module" module-name="library" />
<orderEntry type="module" module-name="reflect" />
<orderEntry type="module" module-name="interactive" />
<orderEntry type="library" name="starr" level="project" />
<orderEntry type="library" name="repl-deps" level="project" />
<orderEntry type="library" name="asm" level="project" />
<orderEntry type="module" module-name="repl" />
</component>
</module>The problem pre-dates this PR, but if you're feeling in the mood to cross all the t-s and dot all the i-s, it would be great to sort this out too. |
|
Oh, I've seen you've added that already. |
|
Would it be possible to merge this to 2.11.x instead, or to backport it? |
|
good point, moving it to 2.11.x |
No description provided.