Skip to content

Use jarlister in build#4799

Closed
rjolly wants to merge 1 commit intoscala:2.11.xfrom
rjolly:scripting15
Closed

Use jarlister in build#4799
rjolly wants to merge 1 commit intoscala:2.11.xfrom
rjolly:scripting15

Conversation

@rjolly
Copy link
Contributor

@rjolly rjolly commented Oct 10, 2015

The goal of this change is to exercize the "manifest classpath" mechanism,
meant to bring the compiler its needed classes as resources, listed
in jar manifests, as opposed to files, thus enabling to use the compiler
in sandboxed environments (and also the scripting engine for that matter).

This is a follow-up to #4456 . For the build to succeed, the jarlister should be added to the bintray under its sha1. It is available from http://repo.maven.apache.org/maven2/com/github/rjolly/jarlister_2.11/1.0/jarlister_2.11-1.0.jar

@adriaanm
Copy link
Contributor

adriaanm commented Feb 9, 2016

Let's rework this to resolve the dependency from maven -- we should eventually remove the pull-binary-libs mechanism.

@rjolly
Copy link
Contributor Author

rjolly commented Feb 9, 2016

Hi Adriaan,
If done with Ant, this would involve interfacing it with Ivy, which was not done before, as far as I can tell. If with Sbt, I will have to implement a Sbt plugin to recover the taskdef mechanism. I am not sure how to do that, is there a good tutorial ?

@adriaanm
Copy link
Contributor

adriaanm commented Feb 9, 2016

Hi @rjolly, thanks for offering to look into it, but I think we should roll this into our work on the sbt build. We can take care of it.

The goal of this change is to exercize the "manifest classpath" mechanism,
meant to bring the compiler its needed classes as resources, listed
in jar manifests, as opposed to files, thus enabling to use the compiler
in sandboxed environments (and also the scripting engine for that matter).
@rjolly
Copy link
Contributor Author

rjolly commented Feb 9, 2016

Okay. Meanwhile I figured out how to do it in Ant.

@SethTisue SethTisue closed this Feb 10, 2016
@rjolly
Copy link
Contributor Author

rjolly commented Feb 11, 2016

@SethTisue @adriaanm you forgot to merge. If intended, it was a bit bold to ask for some more work just before closing.

@rjolly rjolly mentioned this pull request Feb 11, 2016
@adriaanm
Copy link
Contributor

I'm sorry -- I think there has been a misunderstanding. I said "We can take care of it." because I didn't expect you to deal with our build. If you'd like to work on this, you're certainly welcome to!

@SethTisue SethTisue removed this from the 2.11.8 milestone Feb 23, 2016
@SethTisue SethTisue removed the on-hold label Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants