Skip to content

SI-1264 scala -e now outputs compilation messages to stderr#3919

Closed
gourlaysama wants to merge 1 commit intoscala:2.11.xfrom
gourlaysama:wip/t1264-script-runner-fsc-stderr
Closed

SI-1264 scala -e now outputs compilation messages to stderr#3919
gourlaysama wants to merge 1 commit intoscala:2.11.xfrom
gourlaysama:wip/t1264-script-runner-fsc-stderr

Conversation

@gourlaysama
Copy link
Contributor

This makes scala -e send the compilation output from fsc to stderr, just
lile scala -nc -e, and like scalac itself, instead of stdout.

Note that this only aligns fsc with the rest, but it doesn't fix the
actual issue that, currently, a line can be printed without the error
severity and yet be part of an error message, so the severity is useless
for the purpose of discriminating stdout vs. stderr. This ended up with
fsc picking stdout for (mostly) everything and the others stderr. Even
scalac -help sends its output to stderr...

This makes `scala -e` send the compilation output from fsc to stderr, just
lile `scala -nc -e`, and like `scalac` itself, instead of stdout.

Note that this only aligns fsc with the rest, but it doesn't fix the
actual issue that, currently, a line can be printed without the error
severity and yet be part of an error message, so the severity is useless
for the purpose of discriminating stdout vs. stderr. This ended up with
fsc picking stdout for (mostly) everything and the others stderr. Even
`scalac -help` sends its output to stderr...
@gourlaysama
Copy link
Contributor Author

I'm open to suggestions on how to add a test for this. Starting fsc on the server sound like a bad idea. Maybe that's why it isn't tested at all...

@gourlaysama
Copy link
Contributor Author

PLS REBUILD ALL

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 51481868)
🐱 Roger! Rebuilding pr-scala for 0df96b0. 🚨

@gourlaysama
Copy link
Contributor Author

I'm closing this for now, it's actually relatively easy to fix the underlying issue, so I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants