Skip to content

Fix missing and excess nullary / nilary override warnings#10520

Merged
SethTisue merged 5 commits intoscala:2.13.xfrom
lrytz:pr10512
Aug 30, 2023
Merged

Fix missing and excess nullary / nilary override warnings#10520
SethTisue merged 5 commits intoscala:2.13.xfrom
lrytz:pr10512

Conversation

@lrytz
Copy link
Member

@lrytz lrytz commented Aug 28, 2023

Re-submission of #10512 without the changes to namePos.

@scala-jenkins scala-jenkins added this to the 2.13.13 milestone Aug 28, 2023
@som-snytt
Copy link
Contributor

som-snytt commented Aug 28, 2023

The plot thickens!

I thought relying on namePos was less useful if it's not reliable. I did not yet go looking for other places where name text position is calculated.

@lrytz
Copy link
Member Author

lrytz commented Aug 29, 2023

I tested this change (and also the other open 2.13.12 PRs https://github.com/scala/scala/milestone/101) in a customer codebase, it's all good.

The new warning showed up a couple of times, it seems good to have.

trait T { def f(): Int }
trait U { def f = 1 }
// now warns, both under joint and separate compilation. no warning in 2.13.11.
class C extends T with U

@SethTisue SethTisue added the prio:hi high priority (used only by core team, only near release time) label Aug 29, 2023
@SethTisue SethTisue merged commit 35160d4 into scala:2.13.x Aug 30, 2023
@SethTisue SethTisue removed the prio:hi high priority (used only by core team, only near release time) label Aug 30, 2023
@SethTisue
Copy link
Member

SethTisue commented Aug 31, 2023

@som-snytt
Copy link
Contributor

The release thread makes it look a bit weird. My comment on release notes was going to be that people will expect the "migratory" warnings to be entirely consistent (but maybe Lukas missed one). Now I think that maybe "you broke my build by adding warnings but I still don't have coverage stats" may require mollifying remarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants