Skip to content

[nomerge] fix (?) REPL test that intermittently fails on Windows#10338

Merged
SethTisue merged 2 commits intoscala:2.12.xfrom
SethTisue:sd-831
Mar 10, 2023
Merged

[nomerge] fix (?) REPL test that intermittently fails on Windows#10338
SethTisue merged 2 commits intoscala:2.12.xfrom
SethTisue:sd-831

Conversation

@SethTisue
Copy link
Copy Markdown
Member

@SethTisue SethTisue commented Mar 10, 2023

the test was rewritten on the 2.13.x branch and (although I'm not positive) I don't remember seeing it fail there, so this backports the 2.13 version; fingers crossed that will put an end to the intermittent failures

references scala/scala-dev#831

@scala-jenkins scala-jenkins added this to the 2.12.18 milestone Mar 10, 2023
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Mar 10, 2023
@SethTisue SethTisue mentioned this pull request Mar 10, 2023
Closed
SethTisue added 2 commits March 9, 2023 16:24
@SethTisue
update .gitignore
45dad1e
@SethTisue
fix (?) REPL test that intermittently fails on Windows
30158dd 
the test was rewritten on the 2.13.x branch and (although
I'm not positive) I don't remember seeing it fail there,
so this backports the 2.13 version, fingers crossed that
will put an end to the intermittent failures

references scala/scala-dev#831
@som-snytt
Copy link
Copy Markdown
Contributor

som-snytt commented Mar 10, 2023

That's a good idea. The test was rewritten when the REPL was rewritten.

The PR title should probably say fix (?!).

@SethTisue SethTisue changed the title fix (?) REPL test that intermittently fails on Windows fix (?) REPL test that intermittently fails on Windows [nomerge] Mar 10, 2023
@SethTisue SethTisue changed the title fix (?) REPL test that intermittently fails on Windows [nomerge] [nomerge] fix (?) REPL test that intermittently fails on Windows Mar 10, 2023
@SethTisue SethTisue merged commit 4b1dc0b into scala:2.12.x Mar 10, 2023
@SethTisue SethTisue deleted the sd-831 branch March 10, 2023 03:18
@som-snytt
Copy link
Copy Markdown
Contributor

som-snytt commented Mar 10, 2023

I see I tried to reproduce on actual Windows a month ago but could not. I was just trying again with partest run, no luck yet. Or whatever the opposite of luck is. Destiny?

@som-snytt
Copy link
Copy Markdown
Contributor

som-snytt commented Mar 10, 2023

Oh I see an X! but I won't know which test failed until the summary. Wish me luck! or destiny.

@som-snytt
Copy link
Copy Markdown
Contributor

som-snytt commented Mar 10, 2023

gah!

!!    1 - run/t2318.scala                           [non-zero exit code]

or

Exception in thread "main" java.lang.StackOverflowError
        at java.base/java.util.concurrent.ConcurrentHashMap.putIfAbsent(ConcurrentHashMap.java:1541)
        at java.base/java.lang.ClassLoader.getClassLoadingLock(ClassLoader.java:666)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:567)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
        at Test$Mgr$.checkPermission(t2318.scala:16)
        at java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:756)
        at java.base/java.io.File.exists(File.java:829)
        at java.base/jdk.internal.loader.URLClassPath$FileLoader.getResource(URLClassPath.java:1262)
        at java.base/jdk.internal.loader.URLClassPath.getResource(URLClassPath.java:319)
        at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:424)
        at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
        at Test$Mgr$.checkPermission(t2318.scala:16)
        at java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:756)
        at java.base/java.io.File.exists(File.java:829)
        at java.base/jdk.internal.loader.URLClassPath$FileLoader.getResource(URLClassPath.java:1262)
        at java.base/jdk.internal.loader.URLClassPath.getResource(URLClassPath.java:319)

@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 10, 2023

t2318 is a notorious troublemaker

@som-snytt
Copy link
Copy Markdown
Contributor

som-snytt commented Mar 10, 2023

I couldn't decide what tattoo to get on my left forearm, but now I know it must be t2318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Milestone

2.12.18

Development

Successfully merging this pull request may close these issues.

3 participants

@SethTisue @som-snytt @scala-jenkins