[backport] Fixes to backport of new precedence warning#10314
Merged
dwijnand merged 1 commit intoscala:2.12.xfrom Feb 18, 2023
Merged
[backport] Fixes to backport of new precedence warning#10314dwijnand merged 1 commit intoscala:2.12.xfrom
dwijnand merged 1 commit intoscala:2.12.xfrom
Conversation
This is a follow-up for PR 10297 that fixes false positive ambiguity warnings.
lrytz
commented
Feb 16, 2023
| val defPre = pre | ||
| val defCx = cx | ||
|
|
||
| while ((cx ne NoContext) && (cx.owner == defCx.owner || cx.depth >= symbolDepth)) cx = cx.outer |
Member
Author
There was a problem hiding this comment.
This is added; in 2.13:
scala/src/compiler/scala/tools/nsc/typechecker/Contexts.scala
Lines 1606 to 1608 in c47f663
Comment on lines
+1289
to
+1290
| if (outerDefSym == defSym) | ||
| outerDefSym = NoSymbol |
Member
Author
There was a problem hiding this comment.
this is added; in 2.13:
| if (symbolDepth < 0) | ||
| symbolDepth = cx.depth | ||
|
|
||
| def checkAmbiguousWithEnclosing(): Unit = if (foundInSuper && !thisContext.unit.isJava) { |
Member
Author
There was a problem hiding this comment.
isJava is added; in 2.13:
dwijnand
approved these changes
Feb 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #10297 that fixes false positive ambiguity warnings.