Skip to content

don't consider imports when typing package declaration name#10111

Merged
SethTisue merged 1 commit intoscala:2.13.xfrom
lrytz:packageNameMode
Aug 18, 2022
Merged

don't consider imports when typing package declaration name#10111
SethTisue merged 1 commit intoscala:2.13.xfrom
lrytz:packageNameMode

Conversation

@lrytz
Copy link
Member

@lrytz lrytz commented Aug 18, 2022 •
edited
Loading

Similar to Scala 3:

package a.x
class C { def inA = 0 }
package b
import a._
package x {
  class C { def inB = 0 }
}

Before this PR, the PackageDef.pid for b.x refers to the package symbol a.x.

I couldn't spot any uses of PackageDef.pid in the compiler, so it's probably benign.

@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Aug 18, 2022
@lrytz lrytz mentioned this pull request Aug 18, 2022
Merged
@lrytz lrytz requested a review from som-snytt August 18, 2022 09:29
@som-snytt
Copy link
Contributor

som-snytt commented Aug 18, 2022

I guess you mean once Namer does the right thing structurally, no one uses pid.

I was just looking at package names last spring because of scala/bug#12566

You just said about something "we need a mode for that." But was it this?

som-snytt
som-snytt approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good one.

@lrytz
Copy link
Member Author

lrytz commented Aug 18, 2022

I guess you mean once Namer does the right thing structurally, no one uses pid

Maybe I meant I could not find uses of the pid's symbol

You just said about something "we need a mode for that." But was it this?

I don't remember anything here :)

@lrytz lrytz marked this pull request as ready for review August 18, 2022 11:39
@SethTisue SethTisue modified the milestones: 2.13.10, 2.13.9 Aug 18, 2022
@som-snytt
Copy link
Contributor

som-snytt commented Aug 18, 2022

maybe retronym said somewhere we need a mode for this. Thanks again.

@SethTisue SethTisue merged commit 3faf9a9 into scala:2.13.x Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym retronym approved these changes

@som-snytt som-snytt som-snytt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.13.9

Development

Successfully merging this pull request may close these issues.

5 participants

@lrytz @som-snytt @retronym @SethTisue @scala-jenkins