[backport] Accept space separated argument in ChoiceSetting#10099
Merged
retronym merged 1 commit intoscala:2.12.xfrom Aug 1, 2022
Merged
[backport] Accept space separated argument in ChoiceSetting#10099retronym merged 1 commit intoscala:2.12.xfrom
retronym merged 1 commit intoscala:2.12.xfrom
Conversation
som-snytt
approved these changes
Jul 31, 2022
Contributor
som-snytt
left a comment
There was a problem hiding this comment.
That could work. I stared at it for five minutes wondering what it does.
We only care here to support -choice arg for choices.
Glad you were undaunted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of part of #9982, follow-up for #10089