Skip to content

Null type is trivial for warning#10031

Merged
SethTisue merged 1 commit intoscala:2.13.xfrom
som-snytt:issue/trivial-npe
May 10, 2022
Merged

Null type is trivial for warning#10031
SethTisue merged 1 commit intoscala:2.13.xfrom
som-snytt:issue/trivial-npe

Conversation

@som-snytt
Copy link
Copy Markdown
Contributor

Check that type is non-null before using it. (Take null as trivial RHS.)

Follow up #9890 (comment)

@scala-jenkins scala-jenkins added this to the 2.13.10 milestone May 9, 2022
@som-snytt
Copy link
Copy Markdown
Contributor Author

@SethTisue I did not successfully run the sttp build. (sbt starts and shuts down immediately.) If you have a quick hint, I'll try again.

@SethTisue SethTisue modified the milestones: 2.13.10, 2.13.9 May 9, 2022
@SethTisue SethTisue added prio:blocker release blocker (used only by core team, only near release time) internal not resulting in user-visible changes (build changes, tests, internal cleanups) labels May 9, 2022
@SethTisue
Copy link
Copy Markdown
Member

Marking as "internal" since it only modifies as-yet-unreleased code.

I can try this with sttp tomorrow. Recreating community build failures is often tricky enough that it's easiest for me to just do it, especially when (as in this case) any protracted troubleshooting is unlikely to ensue.

@SethTisue SethTisue self-assigned this May 9, 2022
@som-snytt
Copy link
Copy Markdown
Contributor Author

Thanks. Also thanks for not shaming me on Discord.

Let me know if I got the Boolean backward. Or rather, let me know which Boolean I got backward this time.

@SethTisue
Copy link
Copy Markdown
Member

https://scala-ci.typesafe.com/view/scala-2.13.x/job/scala-2.13.x-jdk11-integrate-community-build/3684/console

[info] Project sttp------------------------: SUCCESS (project rebuilt ok)

@SethTisue SethTisue removed the prio:blocker release blocker (used only by core team, only near release time) label May 10, 2022
@SethTisue SethTisue merged commit 3ed3e3f into scala:2.13.x May 10, 2022
@som-snytt som-snytt deleted the issue/trivial-npe branch May 10, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants