Skip to content

Fix bug where -Vtype-diffs sometimes lost error type information#10029

Merged
SethTisue merged 1 commit intoscala:2.13.xfrom
tribbloid:#12561/dev1
Jun 30, 2022
Merged

Fix bug where -Vtype-diffs sometimes lost error type information#10029
SethTisue merged 1 commit intoscala:2.13.xfrom
tribbloid:#12561/dev1

Conversation

@tribbloid
Copy link
Copy Markdown

@tribbloid tribbloid commented May 7, 2022

Fix for scala/bug#12561

@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented May 8, 2022

settings on CI are stricter than local defaults; you can set Global / fatalWarnings := true from the sbt prompt to get the same errors locally

@tribbloid
Copy link
Copy Markdown
Author

Sorry it was a copy-paste typo (def twice), strangely IDE didn't correct me immediately

@tribbloid
Copy link
Copy Markdown
Author

now it is working, not a draft anymore

@SethTisue SethTisue marked this pull request as ready for review May 13, 2022 17:00
@SethTisue SethTisue changed the title Fix for #12561 Fix for scala/bug#12561 May 13, 2022
@SethTisue SethTisue changed the title Fix for scala/bug#12561 Fix bug where -Vtype-diffs sometimes lost error type information May 13, 2022
@tribbloid
Copy link
Copy Markdown
Author

Sorry @SethTisue now all checks have passed, can it be integrated?

@SethTisue SethTisue requested a review from lrytz June 28, 2022 00:09
@SethTisue SethTisue merged commit 0b7118c into scala:2.13.x Jun 30, 2022
@SethTisue
Copy link
Copy Markdown
Member

thank you @tribbloid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants