Merged
Conversation
|
To validate this pull request against other sbt modules, please visit this link. |
This commit simply turns all mutable data structures into concurrent ones.
The Triplequote Hydra Scala compiler may compile a same source file from different workers. Hence, the assertion need to be remove or relaxed. After discussing with @jvican, the assertion is moved behind a strictMode flag as it might still be useful for debugging incremental compiler's issues.
The IncOptions#ignoredScalacOptions field is available since 1.2.0 not 1.3.0.
Had to correct this as otherwise MiMa reports the following issues:
```
[error] * method
of(Int,Double,Boolean,Boolean,Int,java.util.Optional,java.util.Optional,Boolean,java.util.Optional,Boolean,Boolean,Boolean,java.util.Map,Boolean,xsbti.compile.ExternalHooks,Array[java.lang.String])xsbti.compile.IncOptions
in class xsbti.compile.IncOptions does not have a correspondent in current
version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("xsbti.compile.IncOptions.of")
[error] * method
create(Int,Double,Boolean,Boolean,Int,java.util.Optional,java.util.Optional,Boolean,java.util.Optional,Boolean,Boolean,Boolean,java.util.Map,Boolean,xsbti.compile.ExternalHooks,Array[java.lang.String])xsbti.compile.IncOptions
in class xsbti.compile.IncOptions does not have a correspondent in current
version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("xsbti.compile.IncOptions.create")
```
92b8fc2 to
6aeb771
Compare
Contributor
Author
|
@jvican Could you have a look? I'm going to be away from Friday on and I'd really appreciate to have this merged before there are conflicts. Thanks! |
jvican
approved these changes
Dec 30, 2018
Contributor
Author
|
Whohooo! 🍾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405