Closed
Conversation
Closed
93d56bd to
8f3c3fd
Compare
Member
Author
|
Rebased on rebased #455. |
8f3c3fd to
80bb2a2
Compare
Member
Author
|
With #455 merged, rebased on 1.x. |
80bb2a2 to
36f3764
Compare
Member
Author
|
CI was failing because there were files in the 1.x branch that didn't have headers (and this is now enforced by CI). That's now fixed. |
Member
|
First, thank you for doing this. Tests are still failing. Second, I'm travelling these days -- I'll get back to this as soon as I'm home, and I will also reply to the pertinent open thread. |
Member
Author
My pleasure.
Not a worry - safe travels. |
a76039f to
84a64db
Compare
This is a squashed commit. This is a general list of the things that are done. - Port common settings and commands to BuildPlugin - Remove repeated resolvers - Move `relaxNon212` to the build plugin - Move build and alternative publish settings. This commit consolidates the build settings and the settings to set up the alternative publishing process into the `BuildPlugin`. - Move `noPublish` to the `BuildPlugin` - Move the rest of the build logic to the plugin
84a64db to
32d685f
Compare
Member
Member
|
@dwijnand Let's close this, given that either of us have the time to work on this. Please re-open if you wanna tackle it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off this PR builds on #455 ("Merge 1.0.x into 1.x") because there are some build changes differences between 1.0.x and 1.x that I didn't want to merge 3 times (in each PR, and the merge of the PRs). However I can make this PR independent of that if that's better.
This PR is a re-take on @jvican's #428, with a number of adjustments, the two most important ones being (1) it targets the 1.x branch and (2) it uses bare name keys (rather than, e.g "Keys.version"). So it's @jvican's 543dcb0 commit from his #429 build PR.
If this PR is accepted and merged I'll take care of rebasing (and reviewing) @jvican's efforts in #429 so hopefully it too can be merged.
@jvican, please review my re-take here, I'm happy to explain my reasoning.