Drop support for sbt 0.13, make the project build with modern IDE #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Sep 30, 2024
build.sbt
Outdated
|
|
||
| // sbt cross build | ||
| crossSbtVersions := Seq("0.13.18", "1.2.8") | ||
| crossSbtVersions := Seq("1.2.8") |
There was a problem hiding this comment.
suggestion: bump this and you probably won't have to set build.properties in all the tests.
Member
There was a problem hiding this comment.
Likely on old sbt versions to make sure it's compatible since that version, and doesn't depend on anything from newer sbt versions. But should be no problem to just bump to latest now.
6f6daad to
fb9ce92
Compare
kubukoz
approved these changes
Sep 30, 2024
pvlugter
approved these changes
Sep 30, 2024
Member
pvlugter
left a comment
There was a problem hiding this comment.
Yes, fine to bring this all up to date.
Let's make the next release of this plugin at least a minor version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
This PR resolves #30 by throwing error when
libraryDependenciesare overridden instead of silently proceeding.Review guidelines
Since sbt tasks are not allowed to override setting values we can't recover from that otherwise. Those changes are done in
4462537(#32)To make that work I adjusted the build so that you can work on it with modern IDE. This required dropping support for sbt 0.13 that is long unsupported anyway as well as updating native-packager dependency to a recent one. The later has changed it's publish namespace from
com.typesafe.sbttocom.github.sbtsince1.9.xFollowup changes
This PR doesn't rewrite the
build.sbtin tests, which still use the old sbt syntax. I decided to keep them as they are to avoid even more bloated PR, IMO it's better to clean that up in a followup PR.