Skip to content

Publish to Sonatype #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julienrf merged 4 commits into from
Jun 19, 2023
Merged

Publish to Sonatype #26

julienrf merged 4 commits into from
Jun 19, 2023

Conversation

@julienrf
Copy link
Contributor

@julienrf julienrf commented May 31, 2023 •
edited
Loading

Also change organization name to com.github.sbt

Relates to #23, fixes #24

@julienrf
Publish to Sonatype
ad604e1 
Also change organization name to `com.github.sbt`
@julienrf julienrf mentioned this pull request May 31, 2023
Closed
@julienrf julienrf marked this pull request as ready for review May 31, 2023 16:07
@julienrf
Add workflow to release from within the CI
8244bf2 
Anyone with write access to the repository can cut a release.
@julienrf
Copy link
Contributor Author

julienrf commented Jun 1, 2023

Can @pvlugter or @ennru review this PR, please?

This was referenced Jun 1, 2023
Closed
Merged
@julienrf
Copy link
Contributor Author

julienrf commented Jun 1, 2023

Related PR for Scala Steward migration: scala-steward-org/scala-steward#3067

pvlugter
pvlugter approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@julienrf
Copy link
Contributor Author

julienrf commented Jun 2, 2023

Thank you for the review! Before you merge, you will have to set the secrets PGP_PASSPHRASE and PGP_SECRET as explained here: https://github.com/sbt/sbt-ci-release#secrets

@julienrf
Copy link
Contributor Author

julienrf commented Jun 6, 2023

Hey, would you have some time available soon to set the secrets and try publishing a milestone release?

@ennru
Copy link
Contributor

ennru commented Jun 8, 2023

Hey, would you have some time available soon to set the secrets and try publishing a milestone release?

I do not have access to com.github.sbt at Sonatype.

@eed3si9n
Copy link
Member

eed3si9n commented Jun 8, 2023

I think I've set up the Sonatype creds a while back, but it's missing GPG signing key. Let me create that too.

@eed3si9n
Copy link
Member

eed3si9n commented Jun 8, 2023

Added a GPG signing key.

@julienrf @ennru
Fix developers
f86b86c 
Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
@julienrf
Copy link
Contributor Author

julienrf commented Jun 12, 2023

Thank you Enno and Eugene for your help!

@julienrf
Copy link
Contributor Author

julienrf commented Jun 19, 2023

I am going ahead, merging and trying to release an M1 version to see if the workflow works.

@julienrf julienrf merged commit b268233 into sbt:master Jun 19, 2023
@julienrf julienrf deleted the sonatype branch June 19, 2023 13:20
@julienrf
Copy link
Contributor Author

julienrf commented Jun 19, 2023

After a couple of trial and errors, version 0.1.7 is on its way to Maven Central.

https://github.com/sbt/sbt-javaagent/releases/tag/v0.1.7

@pvlugter
Copy link
Member

pvlugter commented Jun 19, 2023

@julienrf great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ennru ennru ennru left review comments

@pvlugter pvlugter pvlugter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Packages missing from any repositroy

4 participants

@julienrf @ennru @eed3si9n @pvlugter