Add option for Scala case class, and easy configuration of other renderers.#98
Merged
eed3si9n merged 1 commit intosbt:masterfrom Apr 20, 2017
Merged
Add option for Scala case class, and easy configuration of other renderers.#98eed3si9n merged 1 commit intosbt:masterfrom
eed3si9n merged 1 commit intosbt:masterfrom
Conversation
0f74e82 to
f91ec29
Compare
Contributor
Author
|
Might be related: #95 |
Contributor
Author
|
Also: #47 |
|
Hi, is there any reason to not merge this PR? It will be pretty useful since the #95 issue it's fixed too |
eed3si9n
approved these changes
Apr 20, 2017
Member
|
The change looks nice. Sorry about the late response. |
Contributor
Author
|
thx |
|
👍 I was justing thinking the same when I saw this! thanks 😄 |
|
I've added the below line in and get the following compile error: |
|
@marko-asplund here https://github.com/sbt/sbt-buildinfo/blob/master/src/sbt-test/sbt-buildinfo/caseclassrenderer/build.sbt#L25 you have a example build with the ScalaCaseObjectRenderer configured. I think you are using the wrong setting key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can now use
To switch to another Renderer. Also added a Case Class renderer, which will create a case class AND an object that inherits the class. This makes it easy to use a jsonFormatter with the output.