Add Java time objects as valid BuildInfoKey values#178
Merged
eed3si9n merged 2 commits intosbt:masterfrom Feb 16, 2022
Merged
Conversation
Author
|
hey @eed3si9n, would this PR be interesting to the project? |
eed3si9n
approved these changes
Jan 21, 2022
Member
eed3si9n
left a comment
There was a problem hiding this comment.
LGTM
sorry about the delayed review
Member
|
CI is still pointing at Travis so it might not succeed, but I'll try to run the tests locally and get it to merge this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our project we tag the release date of each of our components, but we'd like to operate on Java Time classes. This PR adds both
java.time.LocalDateandjava.time.Instant.Due to backwards compatibility I decided not to modify the behavior of
BuildInfoOption.BuildTime