Java Renderers (code generators for Java only sbt projects)#167
Merged
eed3si9n merged 2 commits intosbt:masterfrom Jan 17, 2021
Merged
Java Renderers (code generators for Java only sbt projects)#167eed3si9n merged 2 commits intosbt:masterfrom
eed3si9n merged 2 commits intosbt:masterfrom
Conversation
Member
|
Thanks for the contribution. Testing is documented here https://www.scala-sbt.org/1.x/docs/Testing-sbt-plugins.html. |
4fcd1c6 to
f2489c8
Compare
f2489c8 to
8f25db0
Compare
Contributor
Author
|
Thank you for the links! They were really helpful. I added tests for both renderers. Mostly a copy from your |
Contributor
Author
|
Increased stack for tests (because it was what made them pass on my machine), but it is a separate commit if someone wants to take a look at the stack issue in details. |
eed3si9n
approved these changes
Jan 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java Renderers coming in 2 flavors - with static field and with simple singleton class. Java code requires Java version 1.8. Code was formatted with Google java format.
Additionally I changed
ScalaCaseObjectRendererto public from package private, because I see no reasons why it should be package private.Scala code was formatted with some scalafmt config I used for different project, because no default scalafmt was found in the repo.
No tests, because I'm not familiar how to write tests for SBT plugins.