Skip to content

Use local timezone strings for buildAtString#156

Merged
eed3si9n merged 1 commit intosbt:masterfrom
xerial:local-timezone
Feb 19, 2020
Merged

Use local timezone strings for buildAtString#156
eed3si9n merged 1 commit intosbt:masterfrom
xerial:local-timezone

Conversation

@xerial
Copy link
Copy Markdown
Contributor

@xerial xerial commented Feb 12, 2020

  • buildAtString needs to clarify the timezone by adding Z to the date formatter. Having timezone information is generally a good practice to avoid confusion.
  • I chose the local time zone string instead of UTC so that we don't need to translate UTC timezone into our local time zone in our head.
  • If we need to have UTC representation, buildAtMillis (since 1970-01-01 UTC) still can be used to generate UTC datetime strings.

@eed3si9n eed3si9n merged commit 0a57d6a into sbt:master Feb 19, 2020
@eed3si9n eed3si9n added this to the 0.10.0 milestone Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants