Do not generate multi-parameter infix calls#124
Merged
eed3si9n merged 1 commit intosbt:masterfrom Apr 16, 2018
Merged
Conversation
Multi-parameter infix calls may be removed in the future, so it's better not to generate this kind of code.
Member
|
Scala 2 users are still on 0.7.0 or 0.8.0 will start hitting this when Scala 2.13.3 comes out, thanks to scala/scala#8951 : glad to see it's already fixed :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-parameter infix calls may be removed in the future, so it's better
not to generate this kind of code.
This is blocking us for removing autotupling and multi-parameter infix calls in Dotty (see scala/scala3#4311), because we use sbt-buildinfo to generate the config of the language server when testing (the language server is compiled with Dotty).