Make toJson more JSONish#123
Merged
eed3si9n merged 1 commit intosbt:masterfrom Apr 11, 2018
tonicebrian:master
Merged
Conversation
Member
|
How does the before and after look like? Is this going to be a breaking change for existing users of this feature? |
Member
|
there is a test (that changed). it tests that the code generator generates the right code. but there's no test for the JSON string value that results from running the generated code. how metacan youget 😄 |
Author
|
@eed3si9n Regarding breaking code for existing users, this PR is going to break code that parses because now it will be: I guess that if they were parsing the Json before, it is way easier to adapt the code so they have proper Json lists and options (to the first level of nesting as pointed by @dwijnand ) |
Member
|
ok. I'll be happy to merge this, but we should bump the version number to 0.9.0. |
eed3si9n
approved these changes
Apr 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all HTTP services I make, I add an endpoint
/buildoutputting thetoJsonresult of the BuildInfo. That output is not fully JSON and thus I lack the ability of manipulating output. This pull request is for making that output a bit more JSONish without going full way about adding an external dependency likeakka-http-spray-json.Now I'm able to compare libraries compiled in two instances by doing things like:
curl localhost:8900/build | jq ".libraryDependencies | sort"