Recover from class files and Analysis object getting out of sync.#965
Merged
Recover from class files and Analysis object getting out of sync.#965
Conversation
The sbt#958 describes a scenario where partially successful results are produced in form of class files written to disk. However, if compilation fails down the road we do not record any new compilation results (products) in Analysis object. This leads to Analysis object and disk contents to get out of sync. One way to solve this problem is to use transactional ClassfileManager that commits changes to class files on disk only when entire incremental compilation session is successful. Otherwise, new class files are rolled back to previous state. The other way to solve this problem is to record time stamps of class files in Analysis object. This way, incremental compiler can detect that class files and Analysis object got out of sync and recover from that by recompiling corresponding sources. This commit uses latter solution which enables simpler (non-transactional) ClassfileManager to handle scenario from sbt#958. Fixes sbt#958
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #958 describes a scenario where partially successful results are
produced in form of class files written to disk. However, if compilation
fails down the road we do not record any new compilation results (products)
in Analysis object. This leads to Analysis object and disk contents to get
out of sync.
One way to solve this problem is to use transactional ClassfileManager that
commits changes to class files on disk only when entire incremental
compilation session is successful. Otherwise, new class files are rolled
back to previous state.
The other way to solve this problem is to record time stamps of class files
in Analysis object. This way, incremental compiler can detect that class
files and Analysis object got out of sync and recover from that by
recompiling corresponding sources.
This commit uses latter solution which enables simpler (non-transactional)
ClassfileManager to handle scenario from #958.
Fixes #958