[2.x] feat: Implement ivyless publishLocal#8634
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 27, 2026
Merged
Conversation
Contributor
Author
|
@eed3si9n Could you please review my pr? |
Member
|
I don't have time to do a detailed review, but pretty excited about this one. Thanks for the contribution! |
Contributor
Author
Feel free to do it when you get a chance |
eed3si9n
reviewed
Jan 27, 2026
Comment on lines
+3850
to
+3851
| // Helper to compute hash using MessageDigest | ||
| def computeHash(file: File, algorithm: String): String = { |
Member
There was a problem hiding this comment.
sbt.util.Digest(Digest.Sha1, path) can be used from https://github.com/sbt/sbt/blob/develop/util-cache/src/main/scala/sbt/util/Digest.scala, although Digest probably need a method added to get just the hash string.
Contributor
Author
|
@eed3si9n I've fixed all. Would you mind taking a second look? |
eed3si9n
approved these changes
Jan 27, 2026
Member
eed3si9n
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround. lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements ivyless
publishLocaltask as part of the effort to remove Ivy dependency (#7639).Fixes #8631
Changes:
useIvysetting key (defaults totrue)ivylessPublishLocalImplhelper that publishes without IvypublishLocalto use ivyless publisher whenuseIvy := falselmcoursier.IvyXmldependency-management/ivyless-publish-localFiles changed:
main/src/main/scala/sbt/Keys.scala- new setting keymain/src/main/scala/sbt/Defaults.scala- implementationsbt-app/src/sbt-test/dependency-management/ivyless-publish-local/- scripted testTest plan
mainProj/compilepassesmainProj/testpasses (91 tests)scalafmtCheckAllpassesmimaReportBinaryIssuespassesscripted dependency-management/ivyless-publish-localpassespackageDoc / publishArtifact := false)