[2.x] Fix --sbt-version to expand to -Dsbt.version#8446
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 8, 2026
Merged
[2.x] Fix --sbt-version to expand to -Dsbt.version#8446eed3si9n merged 2 commits intosbt:developfrom
eed3si9n merged 2 commits intosbt:developfrom
Conversation
Member
|
The change lgtm. Could you sign the CLA and let me know plz? |
Contributor
Author
|
@eed3si9n |
Member
|
Let me know if you get a response from the email then. Currenlty CLA check is failing. |
Fixes sbt#6645 The --sbt-version flag was incorrectly trying to download an sbt launcher with the specified version, which doesn't exist for many sbt versions. Changes: - Modified --sbt-version handling to directly add -Dsbt.version property - Removed sbt_version variable assignment that caused launcher mismatch - acquire_sbt_jar now uses default launcher version instead Now --sbt-version X.Y.Z correctly expands to -Dsbt.version=X.Y.Z without affecting the sbt launcher version used to run the build.
3755f86 to
a0f5c83
Compare
Contributor
Author
|
@eed3si9n Both give: "The redirect_uri is not associated with this application" Could you please:
I'm happy to sign however needed. Thanks! |
Member
|
As far as I know, it should be https://contribute.akka.io/contribute/cla/scala/sign. |
Contributor
Author
|
please check again. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6645
The --sbt-version flag was incorrectly trying to download an sbt launcher with the specified version, which doesn't exist for many sbt versions.
Changes:
Now --sbt-version X.Y.Z correctly expands to -Dsbt.version=X.Y.Z without affecting the sbt launcher version used to run the build.