Merged
Conversation
ca5238b to
52bb87f
Compare
**Problem** managedScalaInstance := false fails Java-only tests because the test runner is based on a Scala Runner and sbt 2.x currently derives the ScalaInstance only from update. **Solution** For the purpose of Java-only testing, create a dummy Scala Instance.
52bb87f to
21a9996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8230
Fixes #2640
Problem
Setting
managedScalaInstance := falsefails Java-only tests because the test runner is based on a Scala Runner and sbt 2.x currently derives the ScalaInstance only from update.Solution
For the purpose of Java-only testing, bring back the optimized Scala Instance.