Conversation
**Problem** Zinc added actions in Problem, but it's not yet forwarded to BSP clients. **Solution** As discussed in https://contributors.scala-lang.org/t/roadmap-for-actionable-diagnostics/6172, the plan seems to be to use the `data` field with `actions` inside it, so this implements that.
adpi2
reviewed
May 22, 2023
|
|
||
| ## A Scala action represents a change that can be performed in code. | ||
| ## See also LSP: Code Action Request (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction). | ||
| type ScalaAction { |
Member
There was a problem hiding this comment.
As pointed out by @ckipp01 in build-server-protocol/build-server-protocol#527 (review) this is a duplication of xsbti.Action. I wonder if it would not be simpler to define the xbsti.Action directly as a contra instead. A counter argument is that maybe we don't want util-interface to depend on sjsonnew?
Member
Author
There was a problem hiding this comment.
util-interface and compiler-interface needs to be in Java, but I guess we can make a second subproject for sjsonnew codecs.
Member
There was a problem hiding this comment.
Not sure if it would be better or worse though. I am fine with the PR as it is.
adpi2
approved these changes
May 26, 2023
This was referenced Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also BSP spec update build-server-protocol/build-server-protocol#527
Problem
Zinc added actions in Problem, but it's not yet forwarded to BSP clients.
Solution
As discussed in
https://contributors.scala-lang.org/t/roadmap-for-actionable-diagnostics/6172, the plan seems to be to use the
datafield withactionsinside it, so this implements that.