Skip to content

Scala 2.12.14 / 2.13.6#6522

Merged
eed3si9n merged 3 commits intosbt:developfrom
mkurz:scala_upgrades
May 28, 2021
Merged

Scala 2.12.14 / 2.13.6#6522
eed3si9n merged 3 commits intosbt:developfrom
mkurz:scala_upgrades

Conversation

@mkurz
Copy link
Member

@mkurz mkurz commented May 28, 2021

Similiar to #6426 and #6291

@mkurz
Copy link
Member Author

mkurz commented May 28, 2021

Waiting for typelevel/kind-projector#192... 👀 Merged.

@mkurz mkurz force-pushed the scala_upgrades branch from 180430c to 071b41d Compare May 28, 2021 15:37
@mkurz mkurz force-pushed the scala_upgrades branch from 5f94289 to 3f7193f Compare May 28, 2021 16:13
@mkurz
Copy link
Member Author

mkurz commented May 28, 2021

val hedgehog = "qa.hedgehog" %% "hedgehog-sbt" % "0.6.1"
val disruptor = "com.lmax" % "disruptor" % "3.4.2"
val kindProjector = ("org.typelevel" % "kind-projector" % "0.11.3").cross(CrossVersion.full)
val kindProjector = ("org.typelevel" % "kind-projector" % "0.13.0").cross(CrossVersion.full)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to upgrade kind-projector, but that should be ok:
typelevel/kind-projector@v0.11.3...v0.13.0

lazy val scala212Compiler = "org.scala-lang" % "scala-compiler" % scala212
lazy val scala212Jline = "jline" % "jline" % "2.14.6"
// use the scala-xml version used by the compiler not the latest: https://github.com/scala/scala/blob/v2.12.10/versions.properties#L22
// use the scala-xml version used by the compiler not the latest: https://github.com/scala/scala/blob/v2.12.14/versions.properties#L21
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala-xml version did not change 😅

eed3si9n
eed3si9n previously approved these changes May 28, 2021
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz Thanks for the contribution!

@eed3si9n
Copy link
Member

I guess the question is how safe this is to release without RC cycle. Sometimes Scala 2.12.x includes extra check that starts displaying new warnings. Have you tried using locally baked sbt to a build to see if you see anything weird?

@mkurz
Copy link
Member Author

mkurz commented May 28, 2021

Have you tried using locally baked sbt to a build to see if you see anything weird?

No, but I can do that (later today)

@mkurz
Copy link
Member Author

mkurz commented May 28, 2021

To be able to publish local I needed to upgrade semanticdb as well: https://github.com/scalameta/scalameta/releases

@mkurz
Copy link
Member Author

mkurz commented May 28, 2021

@eed3si9n I did some local testing by publishLocal a 1.5.3-SNAPSHOT. Everything went smoothly. Using that snapshot, I published locally an inhouse sbt-plugin and afterward used that sbt plugin in different projects, which itself also made use of the custom sbt1.5.3-SNAPSHOT.
Everything worked and compiled, without any weird warnings. I also tried a Play Framework project, it ran normally, no warnings.

For me this LGTM.

@eed3si9n
Copy link
Member

Thanks for testing.

@eed3si9n eed3si9n merged commit ea2f496 into sbt:develop May 28, 2021
@mkurz mkurz deleted the scala_upgrades branch May 28, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants