Merged
Conversation
eed3si9n
reviewed
Sep 12, 2020
main/src/main/scala/sbt/internal/server/BuildServerProtocol.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
@eed3si9n Can this PR be integrated in It should be 100% safe since this implementation lives on its own. No existing code is modified. |
eed3si9n
approved these changes
Sep 14, 2020
Member
I merged it, but nothing is totally safe. Sure it's unlikely to invalidate existing builds but if there was a major issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5783
Give BSP clients the ability to trigger a reload by sending a
workspace/reloadrequest.According to the specifiaction in build-server-protocol/build-server-protocol#135, the reload is ignored in case of failure, ie the state of sbt stays the same as before.