Always export apiURL even if autoAPIMappings is false.#2230
Closed
Always export apiURL even if autoAPIMappings is false.#2230
Conversation
|
Can one of the admins verify this patch? |
Member
|
LGTM and please update this for the 1.0 branch :) |
Author
|
Done! :) |
Member
|
Closing in favour of #2262 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple change to make sbt honor the value of
apiURLall of the time. It's not clear from reading the documentation that this is totally ignored whenautoAPIMappingsis false - and it's also an unintuitive interaction, since one setting affects how you generate Scaladoc, while the other affects how you generate your pom.xml.