Fix additional warnings#2142
Merged
Conversation
|
Can one of the admins verify this patch? |
Member
|
Restarted the mvn-local test that had failed. Personally I can't review this easily, as I don't understand some of the changes. I wonder if you could amend the commit message adding detail on anything that isn't pure cosmetics/formatting/parens on why. |
Member
Author
|
Would commenting the changes in the diff do ? |
Member
|
Sure, sounds even better. |
cache/src/test/scala/CacheTest.scala
Outdated
Member
Author
There was a problem hiding this comment.
Scala doesn't like function returning Unit with no params and parens.
Member
Author
|
@eed3si9n Indeed, I'll fix those |
Member
|
Thanks for tending to the garden that's been weedy. |
Member
|
Thanks @pdalpra. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are probably the last warnings I'm confident on fixing without starting to break stuff everywhere :)