Skip to content

Refactor TLS feature flags#135

Merged
sbstp merged 2 commits intosbstp:masterfrom
charlespierce:tls_feature_flags
Nov 5, 2022
Merged

Refactor TLS feature flags#135
sbstp merged 2 commits intosbstp:masterfrom
charlespierce:tls_feature_flags

Conversation

@charlespierce
Copy link
Copy Markdown
Contributor

@charlespierce charlespierce commented Nov 3, 2022

Info

Changes

  • Updated the names of the core TLS features to be more consistent
  • Added aliases to those with the existing feature names
  • Added an internal feature __rustls to indicate Rustls support is enabled (with either kind of root certificates)
  • Updated references in the code to the TLS features to use the new names

Notes

cargo test --no-default-features --features json
cargo test --no-default-features --features tls
cargo test --no-default-features --features tls-rustls
cargo test --no-default-features --features tls-native
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test tls-native-vendored? Just so we know it builds properly

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, updated!

@charlespierce charlespierce marked this pull request as ready for review November 4, 2022 06:42
@sbstp sbstp merged commit 21016ff into sbstp:master Nov 5, 2022
@charlespierce charlespierce deleted the tls_feature_flags branch November 6, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants