Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix how the version for the pkg_set dependency is set by updating both its test cases and the underlying version replacement logic.
- Added a new test case for pkg_set with range specifiers in tests/test_tweak_dependency_version.py.
- Updated the test configuration in tests/test_data/test_pyproject.toml to include pkg_set with both fixed and range specifiers.
- Modified the _replace_dependencies function in python_versions_hook/init.py to remove the forced equality operator so that flexible version specifiers can be used.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_tweak_dependency_version.py | Added test case to assert handling of range specifiers for pkg_set dependency. |
| tests/test_data/test_pyproject.toml | Updated pkg_set entries to support both fixed and range version requirements. |
| python_versions_hook/init.py | Modified dependency replacement logic to directly use the version string as provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.