Due FULLTEXT usage, bump the DB server check to 5.5 ( + MariaDB Support )#654
Merged
Due FULLTEXT usage, bump the DB server check to 5.5 ( + MariaDB Support )#654
Conversation
All of the fields use FULLTEXT https://github.com/sbpp/sourcebans-pp/blob/8d1ecb831af8145aef376864e5993c5edfcde2f4/web/install/includes/sql/struc.sql#L59 https://github.com/sbpp/sourcebans-pp/blob/8d1ecb831af8145aef376864e5993c5edfcde2f4/web/install/includes/sql/struc.sql#L60 https://github.com/sbpp/sourcebans-pp/blob/8d1ecb831af8145aef376864e5993c5edfcde2f4/web/install/includes/sql/struc.sql#L73 This is only supported from Mysql 5.5 onwards and MariaDB 10.0.5 Added extra checks for MariaDB and bumped the requirement from 5.0 to 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All of the fields use FULLTEXT
sourcebans-pp/web/install/includes/sql/struc.sql
Line 59 in 8d1ecb8
sourcebans-pp/web/install/includes/sql/struc.sql
Line 60 in 8d1ecb8
sourcebans-pp/web/install/includes/sql/struc.sql
Line 73 in 8d1ecb8
This is only supported from Mysql 5.5 onwards and MariaDB 10.0.5
Added extra checks for MariaDB and bumped the requirement from 5.0 to 5.5
Motivation and Context
When you are below version 5.5 or MariaDB 10.0.5 you will get SQL fails on creation of tables
How Has This Been Tested?
Fixed the issue, tried the installer.
Now detects and halts the install.
If you give it an up-to-date DB it will continue
Screenshots (if appropriate):
pre-fix:
SQL error (due no FULLTEXT support)
post-fix:
Types of changes
Checklist: