Skip to content

refactor(translations): front-facing message translations#605

Merged
rumblefrog merged 4 commits intov1.xfrom
additional-translations
Sep 26, 2019
Merged

refactor(translations): front-facing message translations#605
rumblefrog merged 4 commits intov1.xfrom
additional-translations

Conversation

@rumblefrog
Copy link
Member

@rumblefrog rumblefrog commented Sep 25, 2019

This moves a good majority of the front-facing messages to translations.

Motivation and Context

Allow ease of translations of hard-coded values. Also closes #582

How Has This Been Tested?

This has not been tested so far.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@rumblefrog rumblefrog requested a review from Groruk September 25, 2019 04:55
TheByKotik
TheByKotik reviewed Sep 25, 2019
View reviewed changes
@CrazyHackGUT
Copy link
Contributor

CrazyHackGUT commented Sep 25, 2019

This is really good idea - move log messages to phrases and don't set obviously used language?
At this moment, your plugin can format log phrases on various languages if someone plugin used SetGlobalTransTarget(), and admin has translation to another languages.

@rumblefrog
Copy link
Member Author

rumblefrog commented Sep 25, 2019

@CrazyHackGUT Not sure if I understand the phrasing, but are you proposing that I do set global translation target.

@CrazyHackGUT
Copy link
Contributor

CrazyHackGUT commented Sep 25, 2019

I propose use %T instead %t and LANG_SERVER (SourceMod define; targets to default SM locale (en; can be changed in core.cfg)) as client for log entries, for example.

TheByKotik
TheByKotik reviewed Sep 25, 2019
View reviewed changes
TheByKotik
TheByKotik reviewed Sep 25, 2019
View reviewed changes
TheByKotik
TheByKotik reviewed Sep 25, 2019
View reviewed changes
TheByKotik
TheByKotik reviewed Sep 25, 2019
View reviewed changes
@TheByKotik
Copy link
Contributor

TheByKotik commented Sep 25, 2019 •
edited
Loading

I propose use %T instead %t and LANG_SERVER (SourceMod define; targets to default SM locale (en; can be changed in core.cfg)) as client for log entries, for example.

No need that.
Both functions ( LogToFile() and LogAction() ) call this on C++ side.

@rumblefrog rumblefrog merged commit 77b9427 into v1.x Sep 26, 2019
@rumblefrog rumblefrog deleted the additional-translations branch September 26, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Groruk Groruk Groruk approved these changes

+1 more reviewer

@TheByKotik TheByKotik TheByKotik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s: review needed semver: minor t: plugin t: translations type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rumblefrog @CrazyHackGUT @TheByKotik @Groruk