Translations for sbpp checker#525
Merged
Conversation
Contributor
|
You don't fully utilize translations. |
Contributor
Author
|
Good catch! This should be fixed, thank you. |
| for (int i = 1; i <= MaxClients; i++) | ||
| { | ||
| SetGlobalTransTarget(i); | ||
| VFormat(msg, sizeof(msg), format, 2); |
Contributor
There was a problem hiding this comment.
This two functions should be called after checking, in game client or not.
Contributor
Author
|
Fixed, along with a mistake I made in sleuth that went unnoticed. |
Contributor
Author
Member
Contributor
Author
|
Done! |
CrazyHackGUT
approved these changes
Oct 19, 2018
rumblefrog
approved these changes
Oct 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have updated sbpp_checker to utilize translations, defined a prefix as with sbpp_main & sbpp_comms, and tweaked a small bit of the language (english) to be a bit more grammatically correct. I have also updated sbpp_sleuth to utilize a prefix, to be uniform with all other plugins, just like above.
Motivation and Context
Don't think this fixes any issues or requests, but provides increased multilingual support.
How Has This Been Tested?
I have tested these changes in depth on both a private and populated public server, however additional testing certainly would not hurt!
Screenshots (if appropriate):
Types of changes
This will require an additional translation file for the checker. Upon next release servers will require this file, so not really breaking.
Checklist: