Include server ID in Native_SBReportPlayer#480
Merged
rumblefrog merged 2 commits intosbpp:v1.xfrom Jun 13, 2018
Merged
Conversation
Web panels uses 0 index value for other ban submission/na
Member
|
Cheers 🎉 |
Contributor
|
Why you just don't get Server ID from DB with subqueries, when Server ID not set? When ban adds into DB, SB tries find own Server ID. |
Member
|
I'm going to hold off doing that as we are planning to remove the need to enter server ID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server ID was missing from the SQL insert statement
Description
Substitute current
0withserverIDglobal variable.Motivation and Context
Current SQL statement has a hard-coded
0for theservertable column, which shows as other server on the ban submissions page.How Has This Been Tested?
Compiled and tested on Linux game server with server ID set in config.
Originating server name confirmed to show properly in ban submissions page on web server.
Types of changes
Checklist: