Skip to content

Admin STEAM_1 ID not converted #486

@ghost

Description

What are the steps to reproduce this issue?

  1. Set admin user steam ID to STEAM_1:...
  2. Log out
  3. Try to log in through Steam

What happens?

Nothing. Silent fail.

What were you expecting to happen?

Logged in.

Any logs, error output, etc.?

n/a

Any other comments?

As of 1.6.3, if the code is designed to do this, it doesn't work. It took me quite some time to figure out that the reason the Steam login did nothing (log in -> back to main page of Sourcebans NOT logged in) was it being STEAM_1 (which doesn't get converted) instead of STEAM_0. (Other ID formats - at least SteamID64 - DO get converted)

It should also say something when an unknown user logs in, but I'll open a separate issue for that. (ETA: #487)

Per #484 STEAM_1 should function. If not, it should be documented nearby. (@Groruk , did you even bother to verify that it worked before closing that issue? Just wondering. Also, this template was a huge waste of my time that frankly shouldn't be necessary.)

What versions of software are you using?

Operating System: Linux (Debian jessie)
SourceBans++ Version: 1.6.3
PHP Version: 5.6.33
MySQL Version: MariaDB 10.0.32
Link to your project: nope.
Link to a phpinfo() output: nope.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions